20 years (bass and guitar)
I'll never be good. I don't ever want to stop learning. I do what I do, because it's who I am. I started playing with people right away; no woodshedding.
An hour at least, though I have been practicing piano more than anything since I started that a year and a half ago (because it didn't make sense to me), and that improves my guitar playing quite a bit. I always have a guitar in my hands when I watch TV/movies, and I always try to write parts to the soundtrack and commercials. I actually encourage my students to play along with commercials, because it helps train the ear, and you don't have time to get comfortable with one key or theme.
Everything. Rock, Reggae, Jazz (of all types), Hispanic/Caribbean, Punk, Folk, Irish trad, Orchestral (I'm looking at the score of the Rite of Spring as I type this*), freaking anything.
*By the way, the SF Symphony put up this awesome series of piece analysis: http://www.keepingscore.org/ Check it out, it's pretty cool.
-Mark